Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEPPER-1340 . fix os pe-cgs child participants proxy name issue #2929

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ssettipalli
Copy link
Contributor

PEPPER-1340
Fix issue with some os-pecgs pediatric participant download not including proxy names.

Root cause:
Osteo1 participants who re-consented and migrated to Osteo2 (Osteo pe-cgs) proxies does not seem to have participants_structured index and hence PHI service couldnt pull proxy names for those participants.
Looks like back in OS1 , PREQUAL was associated with child and DSS skips loading ptp into participants_structured index if NO survey/data.
Newly registered participants seem to have PREQUAL associated with proxy, hence no issue

Solution:
Proxies are in users index for sure, hence pull proxy profile from elastic users index (users.cmi.cmi-osteo) rather than participants_structured index

@@ -91,7 +91,7 @@ public static PhiManifest generateDataForReport(@NonNull ElasticSearchParticipan
if (proxies != null && !proxies.isEmpty()) {
String proxyParticipantId = proxies.get(0);
ElasticSearchParticipantDto proxyParticipant = ElasticSearchUtil.getParticipantESDataByParticipantId(
ddpInstanceDto.getEsParticipantIndex(), proxyParticipantId);
ddpInstanceDto.getEsUsersIndex(), proxyParticipantId);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull proxy profile from users index (ex: users.cmi.cmi-osteo)

@ssettipalli ssettipalli requested a review from zyme August 22, 2024 20:38
Copy link
Contributor

@zyme zyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@ssettipalli ssettipalli merged commit dc514cd into develop Aug 26, 2024
8 checks passed
@ssettipalli ssettipalli deleted the PEPPER-1340-phi-proxy-names-fix branch August 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants